Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Consolidate CSS colors into a single set of variables #46

Open
ryankwirth opened this issue Jun 13, 2020 · 0 comments
Open

[CHORE] Consolidate CSS colors into a single set of variables #46

ryankwirth opened this issue Jun 13, 2020 · 0 comments
Labels
effort: 3 The relative effort to address this issue. state: pending Taking action, but either needs a dependency merged or more data about a bug. type: chore Converting values, reorganizing folder structure, and other necessary (but less impactful) tasks. work: obvious The situation is obvious; best practices used.

Comments

@ryankwirth
Copy link
Collaborator

Purpose

Currently, our color codes are scattered throughout component .css files, and there are quite a few identical ones in different components.

💡 Proposed Implementation:

Create a single file consisting of light- and dark-mode colors defined as CSS variables. These should use the naming scheme from the Material Design color system, like colorPrimary, colorSecondary, colorSurface, etc.

This will allow future components to use a consistent set of colors and improve maintainability if a color needs to be tweaked.

@ryankwirth ryankwirth added effort: 3 The relative effort to address this issue. state: pending Taking action, but either needs a dependency merged or more data about a bug. type: chore Converting values, reorganizing folder structure, and other necessary (but less impactful) tasks. work: obvious The situation is obvious; best practices used. labels Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 3 The relative effort to address this issue. state: pending Taking action, but either needs a dependency merged or more data about a bug. type: chore Converting values, reorganizing folder structure, and other necessary (but less impactful) tasks. work: obvious The situation is obvious; best practices used.
Projects
None yet
Development

No branches or pull requests

1 participant