From 56b2ffdc35ac187eac7950d6252bdd324eb46056 Mon Sep 17 00:00:00 2001 From: "Sean T. Allen" Date: Sun, 3 Dec 2023 22:53:15 +0000 Subject: [PATCH] Stop pushing images to DockerHub We've transitioned to GitHub Container Registry. --- .../release/build-docker-images-on-release.bash | 16 ++-------------- .../release/build-latest-docker-images.bash | 10 ++-------- .github/workflows/latest-docker-image.yml | 5 ----- .github/workflows/release.yml | 5 ----- 4 files changed, 4 insertions(+), 32 deletions(-) diff --git a/.ci-scripts/release/build-docker-images-on-release.bash b/.ci-scripts/release/build-docker-images-on-release.bash index 1119111..8769ec1 100644 --- a/.ci-scripts/release/build-docker-images-on-release.bash +++ b/.ci-scripts/release/build-docker-images-on-release.bash @@ -1,6 +1,7 @@ #!/bin/bash -# *** You should already be logged in to DockerHub when you run this *** +# *** You should already be logged in to GitHub Container Registry when you run +# this *** # # Builds docker release images with two tags: # @@ -52,19 +53,6 @@ set -o nounset # Version: "1.0.0" VERSION="${GITHUB_REF/refs\/tags\//}" -## DockerHub - -NAME="${GITHUB_REPOSITORY}" -# Build and push :VERSION tag e.g. ponylang/ponyup:0.32.1 -DOCKER_TAG="${NAME}:${VERSION}" -docker build --pull -t "${DOCKER_TAG}" . -docker push "${DOCKER_TAG}" - -# Build and push "release" tag e.g. ponylang/ponyup:release -DOCKER_TAG="${NAME}:release" -docker build --pull -t "${DOCKER_TAG}" . -docker push "${DOCKER_TAG}" - ## GitHub Container Registry NAME="ghcr.io/${GITHUB_REPOSITORY}" diff --git a/.ci-scripts/release/build-latest-docker-images.bash b/.ci-scripts/release/build-latest-docker-images.bash index 911e009..a2b3f42 100644 --- a/.ci-scripts/release/build-latest-docker-images.bash +++ b/.ci-scripts/release/build-latest-docker-images.bash @@ -1,6 +1,7 @@ #!/bin/bash -# *** You should already be logged in to DockerHub when you run this *** +# *** You should already be logged in to GitHub Container Registry when you run +# this *** # # Builds docker latest docker images. # @@ -33,13 +34,6 @@ fi # allow above so we can display nice error messages for expected unset variables set -o nounset -## DockerHub - -# Build and push "latest" tag e.g. ponylang/ponyup:latest -DOCKER_TAG="${GITHUB_REPOSITORY}:latest" -docker build --pull -t "${DOCKER_TAG}" . -docker push "${DOCKER_TAG}" - ## GitHub Container Registry # Build and push "latest" tag e.g. ponylang/ponyup:latest diff --git a/.github/workflows/latest-docker-image.yml b/.github/workflows/latest-docker-image.yml index 316aef1..d2c251c 100644 --- a/.github/workflows/latest-docker-image.yml +++ b/.github/workflows/latest-docker-image.yml @@ -15,11 +15,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - name: Login to DockerHub - run: docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD" - env: - DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} - DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} - name: Login to GitHub Container Registry # v2.2.0 uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e2f5c4f..ff13fb1 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -25,11 +25,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - name: Login to DockerHub - run: docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD" - env: - DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} - DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} - name: Login to GitHub Container Registry # v2.2.0 uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc