RFC for introducing JSON access methods #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sketches the consideration for adding `apply()` methods to JSON, together with potential alternatives. ponylang/ponyc#3922
sgebbie
changed the title
jasoncarr0
reviewed
Nov 21, 2021
text/0000-json-getters.md
Outdated
|
|
||
| - document data access: `fun apply(): this->JsonType! => ...`, | ||
| - object data access: `fun apply(): this->Array[JsonType]! => ...`, | ||
| - array data access: `fun apply(): this->Map[String, JsonType]! => ...`. |
There was a problem hiding this comment.
Nit: these !s are not necessary here, but it matters more on the code PR since that shows up in docs
There was a problem hiding this comment.
Fixed in the RFC. I still need to update the code PR.
ponylang/ponyc#3922
ponylang-main
added
the
discuss during sync
SeanTAllen
removed
the
discuss during sync
|
Closing as this doesn't need an RFC anymore as the library in question is now freestanding. |
ponylang-main
added
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an RFC for introducing access methods (getters) into the JSON package so as to facilitate document mutation.
ponylang/json#16