Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Explorer tabs not restored on reload/resume tab #3172

Closed
Tracked by #1617
jmcphers opened this issue May 16, 2024 · 3 comments
Closed
Tracked by #1617

Data Explorer tabs not restored on reload/resume tab #3172

jmcphers opened this issue May 16, 2024 · 3 comments
Assignees
@sharon-wang
Labels
area: data explorer Issues related to Data Explorer category. area: workbench Issues related to Workbench category. bug Something isn't working
Milestone
2024.12.0 Pre-Rel...

Comments

@jmcphers
Copy link
Collaborator

Positron Version:

Positron Version: 2024.05.0 (Universal) build 1255
Code - OSS Version: 1.89.0
Commit: a60c905e786adc4cfccae02d538c5a2ac5ad9b01
Date: 2024-05-16T03:42:49.370Z
Electron: 28.2.8
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin arm64 23.4.0

Steps to reproduce the issue:

  1. Open two editors and two data explorer windows.
  2. Use the Developer -> Reload Window command.

The data explorer windows disappear and aren't restored on reload.

What did you expect to happen?

The data explorers should be restored.

Just as we do with Plots, we should ask the backend to list its open comms to discover the set of data explorers that are still open, and restore tabs for each one.

This is an important feature for Posit Workbench; without it, you'll lose all your open explorers (and any filter/sort state you accumulated in them) if you close your browser tab.
@jmcphers jmcphers added bug Something isn't working area: data explorer Issues related to Data Explorer category. labels May 16, 2024
@jmcphers jmcphers mentioned this issue May 16, 2024
Closed
29 tasks
@jthomasmock jthomasmock added this to the Release Candidate milestone May 19, 2024
@jthomasmock
Copy link
Contributor

Putting this into release candidate as we prep for Workbench integration.

@sharon-wang sharon-wang added the area: workbench Issues related to Workbench category. label Aug 6, 2024
@jmcphers jmcphers mentioned this issue Aug 15, 2024
Merged
@jthomasmock jthomasmock mentioned this issue Oct 4, 2024
Closed
@sharon-wang sharon-wang self-assigned this Nov 18, 2024
This was referenced Nov 20, 2024
Open
Open
This was referenced Nov 22, 2024
Open
Merged
Open
sharon-wang added a commit that referenced this issue Nov 25, 2024
@sharon-wang
reconnect open data explorer editors on reload (#5475)
6ec59a2 
Addresses #3172

### QA Notes

Open data explorer tabs should be restored for both Python and R
sessions when Positron is reloaded. The tabs should appear once the
runtime(s) have started.

See #5462 for notes on what
"reloaded" means across the different Positron builds.

I've tested this in dev builds on Mac for Desktop and Server Web in
Chrome.
@sharon-wang
Copy link
Member

QA Notes

@jonvanausdeln jonvanausdeln mentioned this issue Nov 26, 2024
Open
@jonvanausdeln
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.12.0-80
Workbench Version(s):2024.12.0+456.pro3
OS Version(s) : Ubuntu 24

Test scenario(s)

Data explorer tabs reload as expected. With the notable exception of date explorer tabs opened directly from the datafile (aka headless, duckdb based). See #5523

Link(s) to TestRail test cases run or created:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharon-wang sharon-wang

Labels
area: data explorer Issues related to Data Explorer category. area: workbench Issues related to Workbench category. bug Something isn't working
Projects
None yet
Milestone
2024.12.0 Pre-Release
Development

No branches or pull requests
4 participants
@jmcphers @jonvanausdeln @sharon-wang @jthomasmock