Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return concise output in cases where there are no entries to display in a table for pvsadm purge #698

Open
kishen-v opened this issue Nov 13, 2024 · 4 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@kishen-v
Copy link
Contributor

What happened:
On executing pvsadm purge command across resources, it was observed that an empty table was returned in cases where there are no resources to be deleted. This can be improved to return a simple log stating there are no resources found for deletion.

kishenv@kishen-mbp-m1 ~ % pvsadm purge vms --workspace-id 79e6e139-f6d8-46a6-819-testing123
+------+--------------+-------+------+-----+--------+---------------+
| NAME | IP ADDRESSES | IMAGE | CPUS | RAM | STATUS | CREATION DATE |
+------+--------------+-------+------+-----+--------+---------------+
+------+--------------+-------+------+-----+--------+---------------+

What you expected to happen:
A simple log with the relevant information.

How to reproduce it (as minimally and precisely as possible):
pvsadm purge (across any resource)

Anything else we need to know?:

Environment:

  • pvsadm version (use pvsadm --version):
  • Environment - On-Prem or IBM PowerVS:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Others:
@kishen-v kishen-v added the kind/bug Categorizes issue or PR as related to a bug. label Nov 13, 2024
@kishen-v
Copy link
Contributor Author

kishen-v commented Nov 13, 2024

/remove-kind bug
/good-first-issue
/priority awaiting-more-evidence

@ppc64le-cloud-bot
Copy link
Contributor

@kishen-v:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/remove-kind bug
/kind feature
/good-first-issue
/priority awaiting-more-evidence

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed kind/bug Categorizes issue or PR as related to a bug. labels Nov 13, 2024
@pjsharath28
Copy link

/assign

@kishen-v
Copy link
Contributor Author

The behaviour is slightly different when there are no networks to be purged:

I1115 09:37:04.696844   20688 networks.go:54] Purge networks for the workspace ID: 79e6e139-f6d8-46a6-819c-Testing123

--NO DATA FOUND--
+
+

VMS

kishenv@kishen-mbp-m1 ~ % pvsadm purge vms --workspace-id 79e6e139-f6d8-46a6-819c-Testing123
+------+--------------+-------+------+-----+--------+---------------+
| NAME | IP ADDRESSES | IMAGE | CPUS | RAM | STATUS | CREATION DATE |
+------+--------------+-------+------+-----+--------+---------------+
+------+--------------+-------+------+-----+--------+---------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

3 participants