Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ deps: update argminmax to 0.6.1 #56

Closed
wants to merge 27 commits into from

Conversation

NielsPraet
Copy link
Contributor

Closes #50

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 26, 2023

CodSpeed Performance Report

Merging #56 will degrade performances by 11.53%

Comparing NielsPraet:feat/update-minmax (b279496) with main (b70f614)

Summary

🔥 133 improvements
❌ 4 regressions
✅ 253 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main NielsPraet:feat/update-minmax Change
🔥 test_minmax_no_x[False-float32-5,000-100,000] 2.9 ms 2.2 ms +28.13%
🔥 test_minmax_no_x[False-float32-5,000-1,000,000] 6.4 ms 5.8 ms +10.91%
🔥 test_minmax_no_x[False-float32-1,000-100,000] 1.2 ms 1.1 ms +11.76%
🔥 test_minmax_no_x[False-float64-5,000-100,000] 3.2 ms 2.6 ms +25.44%
🔥 test_minmax_no_x[False-int32-5,000-1,000,000] 7.1 ms 6.4 ms +12.21%
🔥 test_minmax_no_x[False-int32-5,000-100,000] 3.6 ms 2.8 ms +27.99%
🔥 test_minmax_no_x[False-int64-5,000-100,000] 3.8 ms 3.1 ms +23.02%
🔥 test_minmax_no_x[True-float32-1,000-100,000] 1.4 ms 1.3 ms +10.97%
🔥 test_minmax_no_x[True-float32-5,000-100,000] 3.2 ms 2.6 ms +21.56%
🔥 test_minmax_no_x[True-int32-1,000-100,000] 2.2 ms 1.9 ms +11.71%
🔥 test_minmax_no_x[True-int32-5,000-100,000] 3.9 ms 3.2 ms +22.48%
🔥 test_minmax_no_x[True-float64-5,000-100,000] 3.5 ms 3 ms +16.82%
🔥 test_minmax_no_x[True-int32-5,000-1,000,000] 7.5 ms 6.7 ms +11.11%
🔥 test_minmax_no_x[True-int64-5,000-100,000] 4.2 ms 3.5 ms +19.94%
🔥 test_minmax_with_x[False-float32-5,000-100,000] 4.6 ms 3.9 ms +18.78%
🔥 test_minmax_with_x[False-float64-5,000-100,000] 4.9 ms 4.2 ms +17.47%
🔥 test_minmax_with_x[False-int64-5,000-100,000] 5.5 ms 4.7 ms +17.22%
🔥 test_m4_no_x[False-float64-5,000-100,000] 2.3 ms 2 ms +16.11%
🔥 test_m4_no_x[False-float32-5,000-100,000] 1.9 ms 1.6 ms +19.75%
🔥 test_m4_no_x[False-int32-5,000-100,000] 2.6 ms 2.2 ms +17.6%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@jonasvdd jonasvdd requested a review from jvdd July 28, 2023 09:25
@NielsPraet
Copy link
Contributor Author

@jonasvdd now it should be!

@NielsPraet NielsPraet marked this pull request as ready for review July 28, 2023 10:08
@NielsPraet NielsPraet closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⬆️ update to latest argminmax release
2 participants