Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: nan handling #59

Merged
merged 28 commits into from
Feb 2, 2024
Merged

Conversation

NielsPraet
Copy link
Contributor

Closes #24

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 2, 2023

CodSpeed Performance Report

Merging #59 will degrade performances by 37.9%

Comparing NielsPraet:feat/nan-support (7a7cfd3) with main (e4d4a66)

Summary

⚡ 12 improvements
❌ 8 regressions
✅ 370 untouched benchmarks

🆕 288 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main NielsPraet:feat/nan-support Change
🆕 test_nanminmax_with_x[False-float64-1,000-100,000] N/A 2.9 ms N/A
test_minmax_no_x[True-float32-100-1,000,000] 4.8 ms 5.7 ms -15.7%
🆕 test_nanminmax_with_x[False-float64-5,000-1,000,000] N/A 13.9 ms N/A
🆕 test_nanminmax_with_x[False-int32-1,000-100,000] N/A 2.9 ms N/A
🆕 test_nanminmax_with_x[False-float64-1,000-1,000,000] N/A 12.1 ms N/A
🆕 test_nanminmax_with_x[False-int32-100-100,000] N/A 2.5 ms N/A
🆕 test_nanminmax_with_x[False-float64-5,000-100,000] N/A 4.2 ms N/A
🆕 test_nanminmax_with_x[False-int32-100-1,000,000] N/A 6.1 ms N/A
🆕 test_nanminmax_with_x[False-int64-100-100,000] N/A 3.1 ms N/A
🆕 test_nanminmax_with_x[False-int32-1,000-1,000,000] N/A 6.6 ms N/A
test_minmax_no_x[True-float64-100-100,000] 1.6 ms 1.5 ms +11.56%
🆕 test_nanminmax_with_x[False-int64-100-1,000,000] N/A 10.3 ms N/A
🆕 test_nanminmax_with_x[False-int32-5,000-1,000,000] N/A 8.4 ms N/A
🆕 test_nanminmax_with_x[False-int32-5,000-100,000] N/A 4.4 ms N/A
test_minmax_no_x[True-float32-5,000-1,000,000] 7.1 ms 6.4 ms +11%
🆕 test_nanminmax_with_x[False-int64-1,000-1,000,000] N/A 10.7 ms N/A
🆕 test_nanminmax_with_x[False-int64-5,000-100,000] N/A 4.7 ms N/A
🆕 test_nanminmax_with_x[True-float32-100-100,000] N/A 2.4 ms N/A
🆕 test_nanminmax_with_x[False-int64-1,000-100,000] N/A 3.4 ms N/A
🆕 test_nanminmax_with_x[False-int64-5,000-1,000,000] N/A 12.5 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@NielsPraet NielsPraet marked this pull request as ready for review August 4, 2023 08:26
README.md Outdated Show resolved Hide resolved
@jvdd jvdd merged commit af2e304 into predict-idlab:main Feb 2, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💪 handle nans
3 participants