Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🙈 check for contiguous array #64

Merged
merged 2 commits into from
Dec 24, 2023
Merged

🙈 check for contiguous array #64

merged 2 commits into from
Dec 24, 2023

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Dec 24, 2023

Checks #63 and throws an error when this is not the case.

Copy link

codspeed-hq bot commented Dec 24, 2023

CodSpeed Performance Report

Merging #64 will degrade performances by 38.72%

Comparing contiguous (da1d0f7) with main (18b9fdf)

Summary

⚡ 8 improvements
❌ 3 regressions
✅ 379 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main contiguous Change
test_minmax_no_x[True-float32-100-100,000] 1.3 ms 1 ms +25.11%
test_minmax_with_x[True-float32-100-100,000] 2.8 ms 2.5 ms +10.42%
test_minmax_with_x[True-float64-100-100,000] 6 ms 3.3 ms +83.23%
test_m4_no_x[True-float32-100-100,000] 1.4 ms 1.1 ms +24.98%
test_m4_no_x[True-float32-1,000-100,000] 1.4 ms 1.6 ms -15.29%
test_m4_with_x[True-float64-100-100,000] 3.1 ms 5.1 ms -38.72%
test_m4_with_x[True-float32-100-100,000] 2.7 ms 2.5 ms +10.08%
test_m4_with_x[True-int32-1,000-100,000] 7.1 ms 6.2 ms +14.33%
test_m4_no_x[True-int32-1,000-100,000] 2.2 ms 2 ms +11.72%
test_minmaxlttb_no_x[True-float64-100-100,000] 1.8 ms 2.2 ms -17.22%
test_minmaxlttb_no_x[True-int32-100-100,000] 2.3 ms 2.1 ms +10.52%

@jvdd jvdd merged commit e5e4866 into main Dec 24, 2023
34 of 35 checks passed
@jvdd jvdd deleted the contiguous branch January 3, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant