Fix transparent sticky scroll background in the code peek panel #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 09d42d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nNoidea
changed the title
nNoidea
changed the title
|
Did I mess up the PR progress? The problem is still in the latest version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peekViewEditorStickyScroll.backgrounduses the color ofpeekViewEditor.backgroundand is also on top of it.peekViewEditor.backgroundis an rgba color, which means that the sticky scroll features also becomes transparent and the text becomes unreadable when another text is underneath it.peekViewEditor.backgroundcolor seems like a normal rgb (without the alpha channel) color, but that's because the peek panel pushes away all the text underneath itself. The resulting color is the mix ofpeekViewEditor.backgroundrgba andpeekViewResult.backgroundrgb values.Since the sticky scroll feature always uses the color of the background of the panel it is in, this fix will take
peekViewEditor.backgroundandpeekViewResult.backgroundand mix them together into solid color and assign that color to thepeekViewEditorStickyScroll.backgroundto fix the issue.Closes #361
Screenshots
Please provide before/after screenshots for any visual changes
Before:
After:
Before:
After:
Merge checklist
GitHub Light DefaultthemeTake a look at the Contribute section for more information on how test your changes locally.