unit tests do not account for NOTHING_UP_MY_SLEEVE

[ctrlc03]

The unit tests for maci core, do not account that the NOTHING_UP_MY_SLEEVE message is to be inserted at position 0. While not a problem for unit tests, these should be amended.

[wildanvin]

Hello,
I would like to work on this issue please

[ctrlc03]

Hello, I would like to work on this issue please

Awesome, assigned you! thank you and lmk if you need any help/clarification

[wildanvin]

Hello! Sorry for the delay, I got lost in the path of life...

I'll be submitting the PR later this week for sure... I will ask some questions maybe tomorrow in order to make sure I understand everything correctly

[ctrlc03]

Hello! Sorry for the delay, I got lost in the path of life...

I'll be submitting the PR later this week for sure... I will ask some questions maybe tomorrow in order to make sure I understand everything correctly

@wildanvin no problem at all, thanks again for tackling this.

[wildanvin]

So, while reviewing the test files, I noticed that in e2e.test.ts (line 384), there is a check for the correct initialization of the NOTHING_UP_MY_SLEEVE value. It does so by creating a new AccQueue and asserting its zero value with the one of the current poll.

I was planning on doing something similar in the Poll.test.ts file. Would that be OK?