Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart does not have proper updates from operator repo for operator types #8883

Open
tmjd opened this issue Jun 5, 2024 · 2 comments
Open

Comments

@tmjd
Copy link
Member

tmjd commented Jun 5, 2024

Expected Behavior

The helm chart and manifest should have updates pulled from the operator repo before each release.

Current Behavior

Master and Calico v3.28 are not updated with the proper definitions for the operator types. A specific example looking at the v3.28 release, is csi-node-driver is the only allowed container name for the csiNodeDriverDaemonSet but csi-node-driver-registrar and csi-node-driver should also be allowed (based on the CRD in the operator repo). See tigera/operator#3356 for context.

Possible Solution

Ensure the release process properly pulls in updates from the operator repo before creating new releases. It will also be good to pull in updates to the master branch periodically or anytime creating new releases.

Steps to Reproduce (for bugs)

This is an issue with getting the manifests/helm chart updated properly for releases, so no steps necessary to reproduce.

Context

tigera/operator#3356

Your Environment

Not Applicable

@mashiofu-cafex
Copy link

Originated from #8853 which is now closed to monitor this issue

@muckelba
Copy link

We've stumbled across the same problem. I've tried to use the original yaml from the operator repo, but that's not perfect yaml:

kubectl apply --server-side --force-conflicts -f https://github.com/tigera/operator/blob/master/pkg/crds/operator/operator.tigera.io_installations.yaml
error: error parsing https://github.com/tigera/operator/blob/master/pkg/crds/operator/operator.tigera.io_installations.yaml: error converting YAML to JSON: yaml: line 212: mapping values are not allowed in this context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants