We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What version of protobuf and what language are you using? Version: v29.0 Language: C++
What operating system (Linux, Windows, ...) and version? Linux Ubuntu 22.04
What runtime / compiler are you using (e.g., python version or gcc version) GCC 11
What did you do? Steps to reproduce the behavior:
option deprecated = true
--cpp_out=dllexport_decl=...
Specifically seen when building Apache Arrow but a minimal .proto should also work.
What did you expect to see Successful compilation.
Or at least a documented mention of minimum GCC change. I would have thought https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md applied based on https://protobuf.dev/support/version-support/#changes
What did you see instead?
Compilation failure (most likely from 23aada2). Seen while updating to Protobuf 29 in Homebrew Homebrew/homebrew-core#199285
apache-arrow-18.1.0/build/src/arrow/flight/sql/FlightSql.pb.h:6442:31: error: expected identifier before ‘[’ token 6442 | class ARROW_FLIGHT_SQL_EXPORT [[deprecated]] ActionCancelQueryResult final | ^
Anything else we should know about your project / environment
Building in Homebrew environment.
May be related to https://developers.redhat.com/articles/2023/06/21/new-c-features-gcc-13#additional_updates which mentions GCC 13 is the first release to support mixing of GNU and standard attributes.
No compilation issues on GCC 13 or 14.
The text was updated successfully, but these errors were encountered:
sbenzaquen
No branches or pull requests
What version of protobuf and what language are you using?
Version: v29.0
Language: C++
What operating system (Linux, Windows, ...) and version?
Linux Ubuntu 22.04
What runtime / compiler are you using (e.g., python version or gcc version)
GCC 11
What did you do?
Steps to reproduce the behavior:
option deprecated = true
and--cpp_out=dllexport_decl=...
Specifically seen when building Apache Arrow but a minimal .proto should also work.
What did you expect to see
Successful compilation.
Or at least a documented mention of minimum GCC change. I would have thought https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md applied based on https://protobuf.dev/support/version-support/#changes
What did you see instead?
Compilation failure (most likely from 23aada2). Seen while updating to Protobuf 29 in Homebrew Homebrew/homebrew-core#199285
Anything else we should know about your project / environment
Building in Homebrew environment.
May be related to https://developers.redhat.com/articles/2023/06/21/new-c-features-gcc-13#additional_updates which mentions GCC 13 is the first release to support mixing of GNU and standard attributes.
No compilation issues on GCC 13 or 14.
The text was updated successfully, but these errors were encountered: