Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make liveness and readiness probes configurable (#29) #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make liveness and readiness probes configurable (#29) #30

wants to merge 1 commit into from

Conversation

fbuetler
Copy link

@fbuetler fbuetler commented Mar 25, 2024 •
edited
Loading

Resolves #29

Helm template diff of the generated chart (helm template "kafka-ui" charts/kafka-ui):

diff --git a/old b/new
index cf6bb91..ab19b95 100644
--- a/old
+++ b/new
@@ -84,6 +84,8 @@ spec:
             initialDelaySeconds: 60
             periodSeconds: 30
             timeoutSeconds: 10
+            successThreshold: 1
+            failureThreshold: 3            
           readinessProbe:
             httpGet:
               path: /actuator/health
@@ -91,5 +93,7 @@ spec:
             initialDelaySeconds: 60
             periodSeconds: 30
             timeoutSeconds: 10
+            successThreshold: 1
+            failureThreshold: 3            
           resources:
             {}

The newly added successThreshold and failureThreshold correspond to the kubernetes probe defaults.

@fbuetler fbuetler requested a review from a team as a code owner March 25, 2024 10:07
yahel2410
yahel2410 approved these changes Mar 25, 2024
View reviewed changes
Copy link

@yahel2410 yahel2410 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

matake01
matake01 approved these changes Jun 10, 2024
View reviewed changes
Copy link

@matake01 matake01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the expected and needed opportunity

@Haarolean
Copy link
Contributor

Take a look at https://github.com/kafbat/helm-charts, feel free to submit a PR there instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahel2410 yahel2410 yahel2410 approved these changes

@matake01 matake01 matake01 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make liveness/readiness probes configurable
4 participants
@fbuetler @Haarolean @matake01 @yahel2410