Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on Darwin (macOS) when GNU coreutils are on the path #12

Open
therealpxc opened this issue Sep 12, 2017 · 1 comment
Open

Comments

@therealpxc
Copy link

The tests for this program assume that running Darwin means that FreeBSD's coreutils are on the path, but that's not necessarily the case. With the Nix package manager, this breaks builds of tldr because the GNU coreutils are part of the build environment, even on Darwin. This issue will also affect users who have installed the GNU coreutils through Homebrew or some other package manager.

Since running macOS (or *BSD) is actually a distinct proposition from using non-GNU coreutils, the tests should probably reflect that.

@psibi
Copy link
Owner

psibi commented Mar 30, 2018

Sorry for my late reply. I would welcome a PR fixing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants