Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//TODO: Add GL_COPY_READ_BUFFER and GL_COPY_WRITE_BUFFER #428

Open
Mathias-Boulay opened this issue Apr 27, 2023 · 3 comments
Open

//TODO: Add GL_COPY_READ_BUFFER and GL_COPY_WRITE_BUFFER #428

Mathias-Boulay opened this issue Apr 27, 2023 · 3 comments

Comments

@Mathias-Boulay
Copy link
Contributor

Hello again !
For quite a while @PojavLauncherTeam has been stuck trying to implement this //TODO that we found inside the function gl4es_glCopyBufferSubData.

Popular minecraft mods nowadays are using those two buffers, an example being Optifine 1.17+ Render Regions implementation

As far as I am aware, both GL_COPY_READ_BUFFER and GL_COPY_WRITE_BUFFER have used to bind on existing buffers to do a raw copy.

So in theory, when those buffers types are detected on gl4es_glBindBuffer, we should point towards the same buffers as the ones Gl4es handles, then give them back with getbuffer_buffer

But I kinda failed to do that it seems, and I feel like you know what should really be done ?

@ptitSeb
Copy link
Owner

ptitSeb commented Apr 28, 2023

Mmm, I'll have a look, see if I can do some implementation of that.
You know only of Optifine that use it?

@Mathias-Boulay
Copy link
Contributor Author

No, sodium uses it as well !
I'll try to get the code section in question

@Mathias-Boulay
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants