Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/CryptoModule #339

Merged
merged 39 commits into from
Oct 16, 2023
Merged

feat/CryptoModule #339

merged 39 commits into from
Oct 16, 2023

Conversation

mohitpubnub
Copy link
Contributor

@mohitpubnub mohitpubnub commented Sep 19, 2023 •
edited
Loading

fix: Improve security of crypto implementation.

Improved security of crypto implementation by adding enhanced AES-CBC cryptor.

feat: Add crypto module

Add crypto module that allows configure SDK to encrypt and decrypt messages.

@mohitpubnub mohitpubnub marked this pull request as draft September 19, 2023 16:07
@mohitpubnub mohitpubnub changed the title CLEN-1545/ref/enhance-cryptography feat/CryptoModule Sep 25, 2023
@mohitpubnub mohitpubnub marked this pull request as ready for review September 25, 2023 05:53
MikeDobrzan
MikeDobrzan approved these changes Sep 26, 2023
View reviewed changes
Copy link

@MikeDobrzan MikeDobrzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MikeDobrzan
MikeDobrzan approved these changes Sep 26, 2023
View reviewed changes
Copy link

@MikeDobrzan MikeDobrzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better now

@mohitpubnub mohitpubnub self-assigned this Oct 9, 2023
@mohitpubnub mohitpubnub added the status: done This issue is considered resolved. label Oct 9, 2023
@mohitpubnub
Copy link
Contributor Author

@pubnub-release-bot release as v7.4.0

@mohitpubnub mohitpubnub merged commit fb6cd04 into master Oct 16, 2023
6 of 7 checks passed
@mohitpubnub mohitpubnub deleted the CLEN-1545 branch October 16, 2023 11:14
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeDobrzan MikeDobrzan MikeDobrzan approved these changes

@techwritermat techwritermat techwritermat approved these changes

@parfeon parfeon Awaiting requested review from parfeon parfeon is a code owner

@kazydek kazydek Awaiting requested review from kazydek kazydek is a code owner

Assignees

@mohitpubnub mohitpubnub

Labels
status: done This issue is considered resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohitpubnub @pubnub-release-bot @techwritermat @MikeDobrzan