fix: App context event handling for channel and membership #362
Conversation
mohitpubnub
changed the title
Co-authored-by: Serhii Mamontov <parfeon@me.com>
mohitpubnub
added
status: done
| publishMetaData: { | ||
| timetoken: envelope.p.t, |
There was a problem hiding this comment.
Is there a reason to rename field? It is alsready inside of publishMetaData and it doesn't look like that we need to clarify once again that it is publishTimetoken. Is there other reason for it?
There was a problem hiding this comment.
It was typo before.
In eventEmitter (the same code was there in subscriptionManager before) while creating event information object, this was the way we used to assign.
so instead of changing property name in all places (which may be error prone like we have now with channel/membership) I rename it here in subscription utility method.. same as older endpoint implementation here
in short, It's renaming to make is compatible with old implementation logic in event handling
There was a problem hiding this comment.
this can be refactored other way around than as it's there!
For consistent naming, Renamed property name in old subscribe endpoint definition as well
There was a problem hiding this comment.
@parfeon refactored!
|
@pubnub-release-bot release as v7.6.1 |
|
🚀 Release successfully completed 🚀 |
fix: app context events handling.
Fixes issue of App context event handling for channel and membership.