You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To make this package more maintanable (by other people other than me), I'll keep track of some refactors and improvements that would be nice to have before moving this to Pulp organization.
Refactors
Navigation
Don't use string based content-definition (e.g. "{repo}/docs/user/{content}") link
Reason: This requires unnecessary string-parsing/conversion steps that clutter the code without any obvious benefit.
Alternative: Switch to dataclass-based declaration
Better constants/options/enums organization (related to the previous one)
Reason: There is a set of identifier options for persona, content-categories and repo-types, and they have related display names in the docs. This relation should be globally defined
Alternative: Use enums or similar scoped classes consistently
Reason: this info is not used by Repo instances (unnecessarily bloats the class) and makes it confusing to handle reports.
Alternative: move it to another object dedicated to reports
Re-model Repos, Repo, SubPackages to better separate concerns
Reason: With subpackages, the concern of handling repositories (info required for download, path, etc) were mixed with package concerns (display name, relative location in a repository)
Alternative: implement Repo and Package (a generalization of subpackages and single-package repo) with this separation of concerns.
Create PackagesHandler to be responsible for handling the process of download -> placement -> installation
I need to better define those steps conceptually so its easier to understand what is happening and each stage.
To make this package more maintanable (by other people other than me), I'll keep track of some refactors and improvements that would be nice to have before moving this to Pulp organization.
Refactors
Navigation
"{repo}/docs/user/{content}"
) linkRepositories
repolist.yml
overriding and use that in the tests.Testing
Docs
The text was updated successfully, but these errors were encountered: