Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add username label in shared album for added photos #955

Open
Phils80 opened this issue Dec 8, 2023 · 1 comment · May be fixed by #1266
Open

Add username label in shared album for added photos #955

Phils80 opened this issue Dec 8, 2023 · 1 comment · May be fixed by #1266
Labels
feature New feature or request

Comments

@Phils80
Copy link

Phils80 commented Dec 8, 2023

When I'm using shared albums I'm missing information who is owner of the photo, or if preffered who added photo to album. Simply I don't like to use somebody else's photo as my own and then provoke any misunderstandings between users sharing photos in one album.

I would like to have possibility of turning on photos labelling on preview and / or sorting by user / owner.

Now I need to enter "info" and the only thing I can do is to check camera type, sometimes I can find out if it is my photo or I recieved it from somebody, but it is quite frustrating and not effective way.

Similar feature exist in Google Photos, please find photo below:

Screenshot_20231208-123226617 (1)
@Phils80 Phils80 added the feature New feature or request label Dec 8, 2023
jovanbulck added a commit to jovanbulck/memories that referenced this issue Aug 11, 2024
@jovanbulck
feat: Add username label on shared photos
34efe7d 
Fixes pulsejet#955

Signed-off-by: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>
@jovanbulck
Copy link
Contributor

I find this feature really lacking when sharing large albums and/or timelines with multiple people, so I had a shot at implementing this the other day. Currently looks as follows:

Screenshot from 2024-08-10 21-26-00

The nextcloud username is shown in the bottom left of the picture frame for all pictures that are not owned by the logged-in user, both in the Timeline and Albums view.

The added ownership information should also make it easy to implement #787 -- one of the only features that Photos has that Memories doesn't..

Current support is minimal (feedback welcome), but I'll open a PR shortly for implementation-specific discussion.

@jovanbulck jovanbulck linked a pull request Aug 11, 2024 that will close this issue
Open
jovanbulck added a commit to jovanbulck/memories that referenced this issue Aug 12, 2024
@jovanbulck
feat: Add username label on shared photos
d03d6fc 
Fixes pulsejet#955

Signed-off-by: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>
jovanbulck added a commit to jovanbulck/memories that referenced this issue Oct 27, 2024
@jovanbulck
feat: Add username label on shared photos
c3bd526 
Fixes pulsejet#955

Signed-off-by: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>
jovanbulck added a commit to jovanbulck/memories that referenced this issue Oct 27, 2024
@jovanbulck
feat: Add username label on shared photos
8b7c31b 
Fixes pulsejet#955

Signed-off-by: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>
jovanbulck added a commit to jovanbulck/memories that referenced this issue Nov 16, 2024
@jovanbulck
feat: Add username label on shared photos
9a8b709 
Fixes pulsejet#955

Signed-off-by: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add username label on shared photos jovanbulck/memories
2 participants
@jovanbulck @Phils80