Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEIF don't work and PNG is duplicated #811

Closed
JanisPlayer opened this issue Sep 10, 2023 · 1 comment
Closed

HEIF don't work and PNG is duplicated #811

JanisPlayer opened this issue Sep 10, 2023 · 1 comment
Labels
feature New feature or request
Milestone

Comments

@JanisPlayer
Copy link

JanisPlayer commented Sep 10, 2023

I noticed that .HEIF is missing, but .HEIC works. This is likely because it's missing, as indicated in Application.php.

Additionally, there's a small error in base.ts, with PNG being duplicated.

Oh, by the way, I wanted to inquire whether it would be possible to add WebP to Application.php. I've already tested to see if it works. I just wanted to ask if there were any specific reasons why it hasn't been added yet.

When an image is named image.jpeg but is actually stored in a different format like .heif or .svg, it can logically lead to problems. I noticed this due to a bug in Instagram, which doesn't save images with the correct file extension, resulting in faulty loading when using the Zoom with Original File function. This could be resolved by examining the file more closely rather than relying solely on the file name and then providing the correct but harmless file extension, allowing the images to be treated normally again.

However, this is more of an issue caused by "well-programmed" apps like Instagram or user errors. It's not a significant concern because the harmless format is ultimately used. So, it's just a feature.

#812
I have at least added the formats to the PR, if it is accepted I will open the and they can decide.
And that with the idea yes is nice to have but not absolutely necessary if yes everything is stored correctly, therefore that is crossed out.

@JanisPlayer JanisPlayer added the needs triage To be triaged label Sep 10, 2023
@pulsejet
Copy link
Owner

Additionally, there's a small error in base.ts, with PNG being duplicated.

Good catch; this is dead code.

Oh, by the way, I wanted to inquire whether it would be possible to add WebP to Application.php. I've already tested to see if it works. I just wanted to ask if there were any specific reasons why it hasn't been added yet.

No reason particularly. Just that the format isn't widely used for Photos (I don't know if it even supports EXIF headers / manipulation)

@pulsejet pulsejet added feature New feature or request and removed needs triage To be triaged labels Sep 12, 2023
@pulsejet pulsejet added this to the 5.5 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants