Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deserialized Assets are missing Sig #234

Closed
iwahbe opened this issue Apr 26, 2024 · 1 comment · Fixed by pulumi/pulumi#16073
Closed

Deserialized Assets are missing Sig #234

iwahbe opened this issue Apr 26, 2024 · 1 comment · Fixed by pulumi/pulumi#16073
Assignees
@iwahbe
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@iwahbe
Copy link
Member

iwahbe commented Apr 26, 2024 •
edited
Loading

Running this example using an Asset fails with

Diagnostics:
  asset:index:A (ourAsset):
    error: unrecognized signature '' in property map for "localAsset"

As established with @Frassle, it's because the Asset's signature is lost after RegisterResource.

I0426 08:22:01.482624     634 rpc.go:77] Marshaling property for RPC[Provider[command, 0x140019a4480].Check(urn:pulumi:dev::command-ec2-remote::command:remote:CopyFile::copy).news]: 4dabf18193072939515e22adb298388d={c44067f5952c0a294b673a41bacd8c17}
...
I0426 08:22:01.484267     634 rpc.go:292] Unmarshaling property for RPC[Provider[command, 0x140019a4480].Check(urn:pulumi:dev::command-ec2-remote::command:remote:CopyFile::copy).inputs]: 4dabf18193072939515e22adb298388d={}

Copied from #233.
@iwahbe iwahbe added bug Something isn't working awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). labels Apr 26, 2024
@iwahbe iwahbe self-assigned this Apr 26, 2024
iwahbe added a commit to pulumi/pulumi that referenced this issue Apr 26, 2024
@iwahbe
Deserialize Assets with their Sig
d32b488 
This matches the behavior of Archives.

Fixes pulumi/pulumi-go-provider#234
@iwahbe iwahbe mentioned this issue Apr 26, 2024
Merged
6 tasks
iwahbe added a commit to pulumi/pulumi that referenced this issue Apr 26, 2024
@iwahbe
Deserialize Assets with their Sig
c0d8b49 
This matches the behavior of Archives.

Fixes pulumi/pulumi-go-provider#234
github-merge-queue bot pushed a commit to pulumi/pulumi that referenced this issue Apr 26, 2024
@iwahbe
Deserialize Assets with their Sig (#16073)
88b0dd1 
<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

Deserialize Assets with their Sig field set. This is necessary to round
trip them. This matches the behavior of Archives.

Fixes pulumi/pulumi-go-provider#234

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [ ] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Apr 26, 2024
@pulumi-bot pulumi-bot reopened this Apr 26, 2024
@pulumi-bot
Copy link

Cannot close issue:

  • does not have required labels: kind/

Please fix these problems and try again.

@iwahbe iwahbe added kind/bug Some behavior is incorrect or out of spec and removed bug Something isn't working labels Apr 26, 2024
@iwahbe iwahbe closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwahbe iwahbe

Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deserialize Assets with their Sig pulumi/pulumi
2 participants
@iwahbe @pulumi-bot