Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to easily mark output of an invoke as secret #259

Closed
zbuchheit opened this issue Jul 31, 2024 · 3 comments · Fixed by #272
Closed

Add ability to easily mark output of an invoke as secret #259

zbuchheit opened this issue Jul 31, 2024 · 3 comments · Fixed by #272
Assignees
@mikhailshilkov
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@zbuchheit
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

I would like to be able to mark the output of an invoke as always secret similar to how it can be done today for a resource being created with provider:"secret". I expect this is likely because the outputs of the functions are plain strings and not pulumi.Output

Affected area/feature
@zbuchheit zbuchheit added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jul 31, 2024
@mjeffryes mjeffryes removed the needs-triage Needs attention from the triage team label Aug 1, 2024
@zbuchheit zbuchheit mentioned this issue Aug 2, 2024
Open
@t0yv0
Copy link
Member

t0yv0 commented Aug 2, 2024

I believe this needs pulumi/pulumi#12710 codegen work to complete.

@iwahbe iwahbe added the awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). label Aug 5, 2024
@mikhailshilkov mikhailshilkov self-assigned this Sep 17, 2024
@mikhailshilkov mikhailshilkov removed the awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). label Sep 17, 2024
@mikhailshilkov mikhailshilkov mentioned this issue Sep 17, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 24, 2024
@mikhailshilkov
Copy link
Member

This has now been implemented. Note that any provider that will mark its invoke outputs as secrets must use pulumi 3.135.0 or later for its SDK code generation, since the client SDKs need to be able to deserialize secrets appropriately.

We'll cut a new release of pulumi-go-provider as soon as pulumi 3.135.0 is released.

@pulumi-bot
Copy link

This issue has been addressed in PR #272 and shipped in release v0.23.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikhailshilkov mikhailshilkov

Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply secrets to function result properties marked as such pulumi/pulumi-go-provider
6 participants
@t0yv0 @mjeffryes @mikhailshilkov @iwahbe @zbuchheit @pulumi-bot