-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parameterization at the gRPC level #281
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 70.33% 69.23% -1.11%
==========================================
Files 37 37
Lines 4214 5109 +895
==========================================
+ Hits 2964 3537 +573
- Misses 983 1304 +321
- Partials 267 268 +1 ☔ View full report in Codecov by Sentry. |
a28a0b5
to
7f9ba91
Compare
@@ -1091,6 +1110,79 @@ func (p *provider) Cancel(ctx context.Context, _ *emptypb.Empty) (*emptypb.Empty | |||
|
|||
} | |||
|
|||
type ( | |||
// ParameterizeRequest configures the provider as parameterized. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been curious so I searched - https://pulumi-developer-docs.readthedocs.io/latest/docs/architecture/providers.html#parameterized-providers does a much better treatment of this then the doc comments, linking to end to end use cases. Perhaps drop a link here and keep comments especially for elucidating how the go-provider specific things help the user accomplish what's needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs acceptance tests, otherwise LGTM.
d5cb51c
to
42cdc58
Compare
This PR has been shipped in release v0.24.0. |
This PR adds basic support for provider parameterization.