Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parameterization at the gRPC level #281

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Oct 25, 2024

This PR adds basic support for provider parameterization.

@iwahbe iwahbe requested a review from a team October 25, 2024 00:42
@iwahbe iwahbe self-assigned this Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.23%. Comparing base (9378ea6) to head (42cdc58).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
provider.go 80.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   70.33%   69.23%   -1.11%     
==========================================
  Files          37       37              
  Lines        4214     5109     +895     
==========================================
+ Hits         2964     3537     +573     
- Misses        983     1304     +321     
- Partials      267      268       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iwahbe iwahbe force-pushed the iwahbe/support-parameterization branch from a28a0b5 to 7f9ba91 Compare October 25, 2024 01:08
@@ -1091,6 +1110,79 @@ func (p *provider) Cancel(ctx context.Context, _ *emptypb.Empty) (*emptypb.Empty

}

type (
// ParameterizeRequest configures the provider as parameterized.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been curious so I searched - https://pulumi-developer-docs.readthedocs.io/latest/docs/architecture/providers.html#parameterized-providers does a much better treatment of this then the doc comments, linking to end to end use cases. Perhaps drop a link here and keep comments especially for elucidating how the go-provider specific things help the user accomplish what's needed?

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs acceptance tests, otherwise LGTM.

@iwahbe iwahbe force-pushed the iwahbe/support-parameterization branch from d5cb51c to 42cdc58 Compare October 25, 2024 19:02
@iwahbe iwahbe requested a review from t0yv0 October 25, 2024 19:02
@iwahbe iwahbe merged commit 4f9aabc into main Oct 25, 2024
8 checks passed
@iwahbe iwahbe deleted the iwahbe/support-parameterization branch October 25, 2024 21:37
@pulumi-bot
Copy link

This PR has been shipped in release v0.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants