Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak #16

Open
alexeyreznikov opened this issue Jan 13, 2017 · 5 comments
Open

Memory leak #16

alexeyreznikov opened this issue Jan 13, 2017 · 5 comments
Labels
bug

Comments

@alexeyreznikov
Copy link

I found memory leak after library usage. Server rendering.
I've reproduced it here https://github.com/alexeyreznikov/react-ab-test-memory-leak
@wehriam
Copy link
Contributor

wehriam commented Jan 13, 2017

Interesting work, thanks. Any theories as to why this is happening?

@alexeyreznikov
Copy link
Author

I tried to fix it yourself. If to remove call this.setState() here https://github.com/pushtell/react-ab-test/blob/master/src/CoreExperiment.jsx#L61, the memory leak stops.

I'm not very versed in reactjs. And I don't know how to fix it.

@getahead getahead mentioned this issue Jan 16, 2017
Merged
@alexeyreznikov
Copy link
Author

It works great. Thank you!

@peterpme peterpme added the bug label May 5, 2017
@peterpme
Copy link
Collaborator

peterpme commented May 5, 2017

👋 @alexeyreznikov thanks for reporting this bug! Do you mind opening up a pull request with whatever you have and I'll try and help write tests + merge it in?

@okovpashko
Copy link

@wehriam @peterpme PR that fixes this issue is already merged. Could you please close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wehriam @alexeyreznikov @peterpme @okovpashko