[FEATURE] Enable DebuggerPanel in Production #49
Comments
8 tasks
moretti
pushed a commit
to marvelapp/react-ab-test
that referenced
this issue
Feb 4, 2019
<!-- START doctoc generated TOC please keep comment here to allow auto update --> <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --> <h1>Table of Contents</h1> - [Description](#description) - [Motivation and Context](#motivation-and-context) - [How Has This Been Tested?](#how-has-this-been-tested) - [Screenshots (if appropriate):](#screenshots-if-appropriate) - [Types of changes](#types-of-changes) - [Checklist:](#checklist) <!-- END doctoc generated TOC please keep comment here to allow auto update --> <!--- Thank you for your pull request! This is a community supported project initially released by https://github.com/wehriam for your use and enjoyment. --> <!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Add a new method in the debugger (`setDebuggerAvailable`) that allows a developer to override the default setting that makes the debugger unavailable in production builds ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> There are some scenarios where a developer could want to have the debugger enabled in a production build, or change this behaviour at runtime (for instance, have it enabled in an integration environment but disabled in production one). Fixes: #3, pushtell#49 ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> It is a non-breaking change tested with new unit tests. ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [X] My code follows the code style of this project. - [X] My change requires a change to the documentation. - [X] I have updated the documentation accordingly. - [X] I have added tests to cover my changes. - [X] All new and existing tests passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi
What's your thoughts on having an extra ENV variable (maybe REACT_AB_TEST_ENABLE_DEBUGGER_PANNEL) that will enable the debugger panel in production.
If you're setting this then you'll need to run
experimentDebugger.disable();at the top of your app to disable it.I'm happy tp send PR - just want to know if it's a desired feature.
The text was updated successfully, but these errors were encountered: