Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Manual FX #136

Open
jmgomezpoveda opened this issue Apr 18, 2024 · 1 comment
Open

Support for Manual FX #136

jmgomezpoveda opened this issue Apr 18, 2024 · 1 comment
Labels
wontfix This will not be worked on

Comments

@jmgomezpoveda
Copy link

I have disabled auto-fx and sold some USD shares. Now in the report they appear as 100% loss.

image

It seems to be failing to link the multi-line sale operation (in USD) with the single USD-EUR exchange. Sales with auto-fx enabled used to work fine.

In the CSV file, with autofx enabled I can see multiple pairs of lines (one per Buy or Sell line):

02-04-2024,15:40,02-04-2024,UNITED CONTINENTAL HOLDINGS,US9100471096,FX Credit,1.0737,USD,3456.78,USD,0.00,aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee
02-04-2024,15:40,02-04-2024,UNITED CONTINENTAL HOLDINGS,US9100471096,FX Debit,,EUR,-2345.67,EUR,95.80,aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee

However, what I see with auto-fx disabled is one single pair of lines:

18-04-2024,06:57,17-04-2024,,,FX Credit,,EUR,123456.78,EUR,123556.78,
18-04-2024,06:57,17-04-2024,,,FX Debit,1.0699,USD,-234567.89,USD,0.00,

Note that since manual fx operations are not linked to any specific Buy or Sell operation, the last field which used to link the sale and the fx operations is missing, as well as the 4th and 5th fields that indicate the stock which this currency exchange is related to.

@jmgomezpoveda jmgomezpoveda changed the title 100% loss for certain sales with manual fx enabled 100% loss for sales with manual fx enabled Apr 18, 2024
@pviotti
Copy link
Owner

pviotti commented May 1, 2024

the last field which used to link the sale and the fx operations is missing, as well as the 4th and 5th fields that indicate the stock which this currency exchange is related to.

sounds like it's going to be hard to support this if we can't rely on that GUID to be present.
Thanks for reporting this anyway. I'll look into it (if I can find other CSV samples, and time). PRs are welcome too.

edit:
I had a look, and I don't think we can track this at all, since the FX transactions are not correlated in any way to the actual buy and sell transactions. I will mark this as "won't fix" and add it to the list of limitations of degiro-bookkeeper. Thanks again

@pviotti pviotti added the wontfix This will not be worked on label May 6, 2024
@pviotti pviotti changed the title 100% loss for sales with manual fx enabled Support for Manual FX May 6, 2024
pviotti added a commit that referenced this issue May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants