Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Multistep experiments have different time steps at transitions comparing pybamm and liionpack #241

Open
TomTranter opened this issue Mar 31, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@TomTranter
Copy link
Collaborator

liionpack Version

0.3.3

Python Version

23.2

Describe the bug

def test_consistent_results_2_step(self):

This test fails as liionpack creates 21 time points and pybamm 22. The difference is around the transition where pybamm repeats the step at 10 s for the new experiment (ie includes a zero'th entry for cycle 2) and lp doesn't. Liionpack doesn't do any re-initialisation of solutions and fixes time steps at solve. This isn't ideal but it's not a major problem either and would eventually be fixed by merging solver routines into PyBaMM

Steps to Reproduce

No response

Expected behaviour

No response

Relevant log output

No response

Additional context

No response

@TomTranter TomTranter added the bug Something isn't working label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant