Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures and switch to official uv action #80

Open
agriyakhetarpal opened this issue Nov 18, 2024 · 3 comments · May be fixed by #91
Open

Fix CI failures and switch to official uv action #80

agriyakhetarpal opened this issue Nov 18, 2024 · 3 comments · May be fixed by #91
Assignees

Comments

@agriyakhetarpal
Copy link
Member

The uv action is failing on recent PRs because it is not able to find the uv executable. Astral has now adopted the action and moved it to their organisation; we should update and use it from there.

@Saransh-cpp
Copy link
Member

@santacodes would you want to write a quick fix for this?

@santacodes
Copy link
Collaborator

santacodes commented Nov 18, 2024

@santacodes would you want to write a quick fix for this?

I was already on it, the problem with astral-uv action was it didn't have an innbuilt venv support and caching. Would that be a problem? Because then it would mean we write creating and activating venv environment in CI. A potential solution again for that might be using the nox GitHub action and using nox with the uv backend.

I also opened an issue upstream for reference - yezz123/setup-uv#98

@agriyakhetarpal
Copy link
Member Author

I see, I didn't know caching was not enabled. I think it's actually not a big problem, since the local network speeds for GHA runners are fast enough to download dependencies quickly – the benefit is in fast resolution and installation times. I would be okay to proceed without caching.

@Saransh-cpp Saransh-cpp linked a pull request Dec 24, 2024 that will close this issue
@Saransh-cpp Saransh-cpp self-assigned this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants