Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling additional library directories from cibuidwheel #373

Open
jlaine opened this issue Feb 23, 2022 · 0 comments · May be fixed by #374
Open

Handling additional library directories from cibuidwheel #373

jlaine opened this issue Feb 23, 2022 · 0 comments · May be fixed by #374
Labels
enhancement has PR

Comments

@jlaine
Copy link

jlaine commented Feb 23, 2022 •
edited
Loading

In several projects I maintain (e.g. PyAV, aiortc, aioquic..) I need to build additional libraries which then get shipped with the wheels. These additional libraries are built with a custom prefix (/tmp/vendor) so as to keep them explicitly separate from the system libraries.

In order to get auditwheel to pick up the additional libraries, I am forced to add /tmp/vendor/lib to LD_LIBRARY_PATH in my cibuildwheel configuration. However this is very error prone, as it can break other parts of the build.

Would you be open to a PR which introduces an --add-path command-line flag in order to pass additional directories to auditwheel during it's search for libraries? The name of the option was chosen so as to match the one used by delvewheel [1], the Windows counterpart of auditwheel.

[1] https://github.com/adang1345/delvewheel
@jlaine jlaine mentioned this issue Feb 23, 2022
Merged
jlaine added a commit to jlaine/auditwheel that referenced this issue Feb 23, 2022
@jlaine
feature: allow specifying additional library paths (fixes: pypa#373)
f58dd41 
Add new --add-path option to auditwheel repair to search for libraries
in additional directories. This avoid having to manipulate
LD_LIBRARY_PATH in the calling process (e.g. cibuildwheel), as this can
have undesirable side-effects.

The name of the option is chosen to match the one provided by
`delvewheel` on Windows.
jlaine added a commit to jlaine/auditwheel that referenced this issue Feb 23, 2022
@jlaine
feature: allow specifying additional library paths (fixes: pypa#373)
f560107 
Add new --add-path option to auditwheel repair to search for libraries
in additional directories. This avoid having to manipulate
LD_LIBRARY_PATH in the calling process (e.g. cibuildwheel), as this can
have undesirable side-effects.

The name of the option is chosen to match the one provided by
`delvewheel` on Windows.
jlaine added a commit to jlaine/auditwheel that referenced this issue Feb 24, 2022
@jlaine
feature: allow specifying additional library paths (fixes: pypa#373)
ae0aae5 
Add new --add-path option to auditwheel repair to search for libraries
in additional directories. This avoid having to manipulate
LD_LIBRARY_PATH in the calling process (e.g. cibuildwheel), as this can
have undesirable side-effects.

The name of the option is chosen to match the one provided by
`delvewheel` on Windows.
@mayeut mayeut linked a pull request Feb 27, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement has PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: allow specifying additional library paths (fixes: #373) jlaine/auditwheel
2 participants
@jlaine @mayeut