Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate away from star import for explicit ones #599

Open
jGaboardi opened this issue Oct 23, 2023 · 2 comments
Open

migrate away from star import for explicit ones #599

jGaboardi opened this issue Oct 23, 2023 · 2 comments
Assignees
@jGaboardi @martinfleis
Labels
maintenance

Comments

@jGaboardi
Copy link
Member

xref: #597 (comment)

Migrate away from star import for explicit ones. Once complete we can remove "F403", # star import; unable to detect undefined names in pyproject.toml.
@martinfleis
Copy link
Member

Ideally, instead of from .alpha_shapes import * we should do import alpha_shapes and then use alpha_shapes.function in the code. That way we minimise ambiguity of what comes from where.

In __init__.py, we could potentially leave stars but I bet there are other, better solutions than that.

@jGaboardi
Copy link
Member Author

Agreed.

@jGaboardi jGaboardi mentioned this issue Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

@martinfleis martinfleis

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jGaboardi @martinfleis