Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nodata detection is more robust in raster builders #741

Open
martinfleis opened this issue Jul 6, 2024 · 0 comments
Open

Ensure nodata detection is more robust in raster builders #741

martinfleis opened this issue Jul 6, 2024 · 0 comments

Comments

@martinfleis
Copy link
Member

As pointed out in #740, the only case when our raster contiguity builders capture nodata information is when that is encoded in da.attrs["nodatavals"]. I am not sure when that happens but I've seen more DataArrays where missing is encoded differently. Usually, da.rio.nodata can pick that but on float array, you can also have np.nan etc. We shall revise this logic and make it a bit more robust so a user does not have to manually add nodatavals to attrs before building the graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants