Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place history file in $XDG_STATE_HOME #923

Closed
microo8 opened this issue Nov 5, 2022 · 7 comments
Closed

Place history file in $XDG_STATE_HOME #923

microo8 opened this issue Nov 5, 2022 · 7 comments
Labels
category: ui ux Everything ui / ux priority 3: low Default for enhancements

Comments

@microo8
Copy link

microo8 commented Nov 5, 2022

The history file is now by default in $XDG_CACHE_HOME (~/.cache/). Which is a problem, because the cache folder is just for caching data. When I run BleachBit it deleted my history file :(

The better approach would be to save the history file in $XDG_DATA_HOME (~/.local/share) or even better in $XDG_STATE_HOME (~/.local/state) where also nvim, pipewire, tofi and others store history and logs.

@Derisis13
Copy link
Collaborator

$XDG_STATE_HOME is a good idea. Can we squeeze it into #922 ?

@CoolnsX
Copy link
Collaborator

CoolnsX commented Nov 5, 2022

Yus we can.. we hv to Provide the documentation on moving the history file to that location..

@CoolnsX CoolnsX closed this as completed Nov 5, 2022
@CoolnsX CoolnsX reopened this Nov 5, 2022
@Derisis13 Derisis13 added priority 3: low Default for enhancements category: ui ux Everything ui / ux labels Nov 8, 2022
@Derisis13
Copy link
Collaborator

On a second thought maybe we shouldn't just shove it into a minor release. This would require some interaction from the users and should get a separate version.

@port19x
Copy link
Collaborator

port19x commented Dec 13, 2022

I doubt the inconvenience of the history file being in the $XDG_CACHE_HOME is even remotely as big as the inconvenience of moving the history file on a version upgrade.

The only way this would get implemented is if we either find a way to move the history file in a non-disruptive way, or if we need to restructure the history file in the future

@port19x
Copy link
Collaborator

port19x commented Dec 13, 2022

This could be done by checking for an existing file in $XDG_CACHE_HOME and creating a hardlink to that file.
If such a file does not exist, fresh history files would be placed in XDG_STATE_HOME

@Derisis13
Copy link
Collaborator

fixed by #955

@Derisis13
Copy link
Collaborator

This was done in v4, along with overwritable history path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ui ux Everything ui / ux priority 3: low Default for enhancements
Projects
None yet
Development

No branches or pull requests

4 participants