Problem with test_reset_parameters() in test_hsn_layer.py

[pavlo-melnyk]

Hi!

In test_reset_parameters()

TopoModelX/test/nn/simplicial/test_hsn_layer.py

Line 34 in ed4bd96

if isinstance(module, torch.nn.Conv2d):

, the HSNLayer modules are checked to be instances of torch.nn.Conv2d. However, none of them are, since the layer consists of only Aggregation (from topomodelx.base.aggregation) and Conv from (topomodelx.base.conv).

Thus, the test will be passed without actually checking the parameter reset.

(The test itself is incorrect: after resetting, the parameters of a torch.nn.Conv2d layer are compared to zeros

TopoModelX/test/nn/simplicial/test_hsn_layer.py

Line 36 in ed4bd96

module.weight, torch.zeros_like(module.weight)

, which is not how they are initialized.)