Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and parse the admonition node #38

Open
stsewd opened this issue Oct 18, 2020 · 2 comments
Open

Implement and parse the admonition node #38

stsewd opened this issue Oct 18, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@stsewd
Copy link
Member

stsewd commented Oct 18, 2020

We have a Note node

lira/lira/parsers/nodes.py

Lines 137 to 143 in f05975a

class Note(Node):
valid_options = {"title"}
def __str__(self):
title = self.options["title"]
return f"{self.tagname} ({title}): {self.children}"

but we actually want an Admonition node with different types (note, warning, tip).

@stsewd stsewd added the enhancement New feature or request label Oct 20, 2020
@stsewd
Copy link
Member Author

stsewd commented Oct 21, 2020

Or maybe we are fine having a different class?

@stsewd
Copy link
Member Author

stsewd commented Oct 25, 2020

This is implemented, we need to parse it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant