-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid running TOR003 by default #21
Comments
I think that's fine that sometimes autofix is not correct, as it's not possible to make it work correctly in every case.
The idea is to provide the recommended value (as the doc for There is another rule with similar risk of unsafe behavior - "TOR102 Maybe we should designate autofixes as |
And maybe it's possible to detect some cases when |
Maybe we could offer safe and unsafe versions of each fix when possible? If both modes exist, I would imagine users would first try running with unsafe, and if anything breaks, fallback to safe mode. I feel like this would be a good default for the users who don't have the time to actually dive in to debug anything, but still want to make sure their code is compliant for the most part.
Yeah this will be hard to do statically, unfortunately |
Today, use_reentrant defaults to True, but TOR003 sets use_reentrant=False which may subtly differ in behavior in certain cases. We should either make TOR003 set use_reentrant=True, or not run it by default.
cc @kit1980
The text was updated successfully, but these errors were encountered: