-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry checker into processing #59637
Open
Djedouas
wants to merge
11
commits into
qgis:master
Choose a base branch
from
Djedouas:geometry_checker_into_processing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djedouas
force-pushed
the
geometry_checker_into_processing
branch
from
November 28, 2024 17:02
54438c3
to
2bd6a42
Compare
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Djedouas
force-pushed
the
geometry_checker_into_processing
branch
3 times, most recently
from
December 5, 2024 16:33
2f69603
to
07d1492
Compare
Djedouas
force-pushed
the
geometry_checker_into_processing
branch
from
December 5, 2024 17:13
03f2a75
to
41d2499
Compare
Djedouas
force-pushed
the
geometry_checker_into_processing
branch
from
December 6, 2024 10:24
41d2499
to
d16face
Compare
Porting angle check from geometry checker to processings
Porting angle fix from geometry checker to processings
Porting area check from geometry checker to processings
Porting area fix from geometry checker to processing
Porting hole check from geometry checker to processings
Porting hole fix from geometry checker to processings
Porting missing vertex check from geometry checker to processings
Porting missing vertex fix from geometry checker to processings
… and auto keywords
for more information, see https://pre-commit.ci
Djedouas
force-pushed
the
geometry_checker_into_processing
branch
from
December 9, 2024 15:19
d16face
to
cc42df1
Compare
Great job @Djedouas and well documented! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #55939
This Pull Request aims to integrate the geometry checker in the processing toolbox within the scope of QEP 236.
Each process will follow a consistent logic: one input layer and two distinct outputs.
For check processing outputs are
For fix processing outputs are
To ensure a consistent user experience, each process will operate similarly:
A default tolerance parameter is set at 8 (for 1e-8) in the advanced settings of every processing.
Demo video
https://vimeo.com/991495790
Screenshots
1. Check errors
Check geometry: errors will be created as a point layer showing places where the angle is < min angle
Launch processing
Errors layer attribute table
Source and errors layer
2. Fix with appropriate processing
Launch the delete vertex processing With the errors layer (output from the previous check) as input
Source and fixed layer (neon red)
Report layer showing what was done
Remarks - feedbacks welcome
The new processes are grouped under new categories named "Check geometry" and "Fix geometry". Suggestions for improved naming are welcome. The aim is to unify verification and correction processes from topology and geometry_checker plugins within these categories.
The current displayName, "Check/FIX Geometry (algorithm name)", is provisional. Any suggestions for enhancing this are welcome.
To avoid overwhelming process options, I've opted to enforce the "gc_" prefix for field names (see outputFields). It's worth considering whether to make this parameter configurable.
Next
Other Geometry Checker processes will be added following this review, and we plan to include additional correction/manipulation processes.
Funded by QGIS (Grant OpenSource 2023) and Oslandia
Part of qgis/QGIS-Enhancement-Proposals#236
cc @lbartoletti