Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QgsMapBoxGlStyleConverter): also handle text-rotate from property field #59984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benoitdm-oslandia
Copy link
Contributor

Fix issue when a text-rotate is defined according a field value as this example:

 {
            "id": "World",
            "type": "symbol",
            "source": "esri",
            "layout": {
                "text-size": 13.3333,
                "text-rotate": {
                    "property": "_label_angle1",
                    "default": 0,
                    "type": "identity"
                },
                "text-field": "{_name1}",
                "text-optional": true,
                "visibility": "none"
            },

},

@benoitdm-oslandia benoitdm-oslandia self-assigned this Dec 20, 2024
@github-actions github-actions bot added this to the 3.42.0 milestone Dec 20, 2024
@benoitdm-oslandia
Copy link
Contributor Author

@3nids I am not sure about my solution with the expression. Does it look fine to you?

Copy link

github-actions bot commented Dec 20, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 64cc147)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 64cc147)

Copy link
Member

@3nids 3nids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but I must say I am quite surprised that we don't have any other property/identity occurence in the current code.

@benoitdm-oslandia
Copy link
Contributor Author

Looking good, but I must say I am quite surprised that we don't have any other property/identity occurence in the current code.

Yes indeed! FYI the implied json is https://www.arcgis.com/sharing/rest/content/items/50cb5f2dfaaf4ccb88f37be2d8e5661e/resources/styles/root.json

@benoitdm-oslandia benoitdm-oslandia force-pushed the fix/vector_tile_text-rotate branch from 9680af9 to 64cc147 Compare December 20, 2024 10:03
@benoitdm-oslandia
Copy link
Contributor Author

@3nids I made the fix, is it ok?

Copy link
Member

@3nids 3nids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants