-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(QgsMapBoxGlStyleConverter): also handle text-rotate from property field #59984
base: master
Are you sure you want to change the base?
fix(QgsMapBoxGlStyleConverter): also handle text-rotate from property field #59984
Conversation
@3nids I am not sure about my solution with the expression. Does it look fine to you? |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but I must say I am quite surprised that we don't have any other property/identity occurence in the current code.
Yes indeed! FYI the implied json is https://www.arcgis.com/sharing/rest/content/items/50cb5f2dfaaf4ccb88f37be2d8e5661e/resources/styles/root.json |
9680af9
to
64cc147
Compare
@3nids I made the fix, is it ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good
Fix issue when a text-rotate is defined according a field value as this example: