Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including the master pid in the filename makes monitoring harder #20

Open
luisbosque opened this issue Oct 4, 2012 · 2 comments · May be fixed by #31
Open

Including the master pid in the filename makes monitoring harder #20

luisbosque opened this issue Oct 4, 2012 · 2 comments · May be fixed by #31

Comments

@luisbosque
Copy link

Monitoring the cluster from a external tool (monitor for example) it's pretty difficult or impossible if the pidfile name includes the pid itself.
It's ok adding pid in the workers pidfiles names but not in the master one.
I believe the master pid should be master.pid.
@strk
Copy link
Contributor

strk commented Oct 4, 2012

+1, why would anyone want the pid in the file name ? You tilically read a pid file because you want to know the PID, you don't know it in advance...

luisbosque added a commit to CartoDB/cluster2 that referenced this issue Dec 11, 2012
@luisbosque
Remove pid from master pidfile name. Closes ql-io#20.
bed2f38 
There's no use of a .pid file storing the PID if you need to know
the PID in order to read the file...
@strk
Copy link
Contributor

strk commented Dec 11, 2012

superceeded by pull request #28

@strk strk linked a pull request Jan 29, 2013 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove pid from master pidfile name CartoDB/cluster2
2 participants
@luisbosque @strk