Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Support? #34

Open
dakami opened this issue Feb 26, 2013 · 7 comments
Open

SSL Support? #34

dakami opened this issue Feb 26, 2013 · 7 comments

Comments

@dakami
Copy link

dakami commented Feb 26, 2013

Not obvious how to SSL-ize an express connection. Any tips?

@shimonchayim
Copy link
Member

Hi dakami, I agree an example will help. Cert, etc will be configured in express because all c2 does is listen on the provided ports to serve the app. But will try to put together an example.

@dakami
Copy link
Author

dakami commented Feb 27, 2013

Much appreciated. This is actually the best way to make Node multi-core right now (congratulations), so your reward for excellent work is more work.

@shimonchayim
Copy link
Member

@alumowa
Copy link

alumowa commented Mar 1, 2013

This might be more trouble than it's worth but it would actually be pretty neat to be able to support http & https apps at the same time for those who wants to secure portions of their site. Looking at the source it seems rather iffy to stuff that support in though, any ideas?

@shimonchayim
Copy link
Member

C2 only listens on the ports provided to server the app(s) (again provided by user). If express, etc server is configured with certificates then I am not sure if anything needs to be done in C2.

@dakami
Copy link
Author

dakami commented Mar 2, 2013

Cluster2 only listens on one port (well, it also listens on Monitor, but that's a bug). I could run two clusters, even going so far as to dual-process each core, but then I'm posting sessions to the same express app. If I have two apps, one with and one without ssl, I need to double configure both apps to have all the routing wired up.

What I want is a hook that says, if the app saw its comms come in from SSL, then use this SSL config but otherwise be normal.

@shimonchayim
Copy link
Member

Cluster2 can run on as many ports as you like. We need to update the doc
but we have recently made changes were you can can pass Express App and
port pair and cluster2 will serve them.
Here is an example:
https://github.com/ql-io/netmorphic-template/blob/master/index.js

On Fri, Mar 1, 2013 at 4:32 PM, dakami notifications@github.com wrote:

Cluster2 only listens on one port (well, it also listens on Monitor, but
that's a bug). I could run two clusters, even going so far as to
dual-process each core, but then I'm posting sessions to the same express
app. If I have two apps, one with and one without ssl, I need to double
configure both apps to have all the routing wired up.

What I want is a hook that says, if the app saw its comms come in from
SSL, then use this SSL config but otherwise be normal.


Reply to this email directly or view it on GitHubhttps://github.com//issues/34#issuecomment-14319249
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants