Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow expect_snapshot_value() to ignore attributes #1772

Closed
DanChaltiel opened this issue Apr 10, 2023 · 1 comment
Closed

Allow expect_snapshot_value() to ignore attributes #1772

DanChaltiel opened this issue Apr 10, 2023 · 1 comment

Comments

@DanChaltiel
Copy link

Attributes are often of lesser importance and checking on them unnecessarily clutters the output.

For instance, expect_snapshot_value(x, ignore_attributes=TRUE) would be very nice to use.

Also, this could sometimes allow using nicer styles, as shown in #1771.

@hadley
Copy link
Member

hadley commented Jul 26, 2023

Isn't ... already passed on to waldo::compare()? That's certainly what the docs and code suggests to me.

@hadley hadley closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants