Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different behaviour in Windows before and after running library(zip) #116

Open
context-dependent opened this issue Jun 27, 2024 · 0 comments

Comments

@context-dependent
Copy link

Ran into this issue on Windows 11, attempting to unzip an archive with descendent files having names that include single quotes.

An example directory structure:

problematic-filenames.zip
   /l'esprit du corps.png

After installing, but prior to running library(zip),

zip::unzip("problematic-filenames.zip")

Panics and exits with error code 1, R_ZIP_EOPEN.

After running library(zip), identical calls produced the desired result in current and subsequent sessions, even after reinstalling the zip package.

I don't know how to reproduce the error, as I don't know how to undo the side-effect(s) of library(zip), but I do know that the default zip tool in windows 11 will panic when asked to zip folders with files whose paths contain single quotes.

The problem with this difference is that, when r-lib/zip is imported into another package as a dependency, users of the dependent package on Windows may experience unforeseen errors if they haven't called library(zip), which seems bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant