-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: allow manual specification of the ZIP directory structure #50
Labels
feature
a feature request or enhancement
Comments
Yeah, I think that would be pretty cool. A PR is welcome. |
gaborcsardi
added
enhancement
feature
a feature request or enhancement
and removed
enhancement
labels
May 8, 2020
AshesITR
added a commit
to AshesITR/zip
that referenced
this issue
May 9, 2020
This was referenced May 9, 2020
gaborcsardi
pushed a commit
that referenced
this issue
Jul 10, 2020
gaborcsardi
pushed a commit
that referenced
this issue
Jul 10, 2020
@gaborcsardi are you still interested in this feature? If so, I can try rebasing #51 onto current |
Yes, sorry for the wait. I'll look at it soon, before the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be fantastic to allow for manual specification of the ZIP directory structure in a
zip::zipr
orzip::zipr_append
call, e.g.I skimmed the code and think it shouldn't be too hard by changing the
key
inget_zip_data()
if names are present.I can give it a try if you think that feature would be useful.
Ideally:
The text was updated successfully, but these errors were encountered: