Packaging redo #67
Merged
Packaging redo #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufae
reviewed
Oct 21, 2024
r2ai/main.py
Outdated
|
|
||
| def r2ai_rlang_plugin(unused_but_required_argument): | ||
| print('hello') |
trufae
requested changes
Oct 21, 2024
trufae
reviewed
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
I was having a very hard time running this from scratch in all the various ways (pipe/plugin/cli)
The idea here is that we have r2ai/cli.py and r2ai/plugin.py. No more .py in root, which solves a lot of the annoying relative import issues.
You can now run it for dev with ./r2ai.sh for dev and via python -m r2ai.(cli/plugin)
Removed requirements.txt, it's in pyproject.toml.