You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've got a nice-to-have feature request. No bug or urgent need, but it doens't look hard to implement. I just wanted to make sure Thor::Shell::HTML is deprecated before working on a PR.
I'm not really sure who is using Thor::Shell::HTML or how they use it. I haven't seen much documentation or usage so I realize it might be partially supported.
Having said that, I have come across situations where I'd like a command I'd like to give users the option between text (Thor::Shell::Colored), Markdown or HTML output. This makes a lot of sense for the print_table command, which has:
Text tables (color not shown on GitHub)
Suite Scenario Implementor Status
Katas hello world ruby Fully Verified (2 of 2)
Katas hello world java Fully Verified (2 of 2)
Katas hello world python Fully Verified (2 of 2)
Katas quine ruby <Not Found>
Katas quine java Fully Verified (2 of 2)
Katas quine python Fully Verified (2 of 2)
Markdown Tables (not in original markdown, but common extension supported by GFM and others)
Suite | Scenario | Implementor | Status
------|----------|-------------|-------
Katas | hello world | ruby | Fully Verified (2 of 2)
Katas | hello world | java | Fully Verified (2 of 2)
Katas | hello world | python | Fully Verified (2 of 2)
Katas | quine | ruby | <Not Found>
Katas | quine | java | Fully Verified (2 of 2)
Katas | quine | python | Fully Verified (2 of 2)
HTML (equivalent to GFM-rendered Markdown)
<table><thead><tr><th>Suite</th><th>Scenario</th><th>Implementor</th><th>Status</th></tr></thead><tbody><tr><td>Katas</td><td>hello world</td><td>ruby</td><td>Fully Verified (2 of 2)</td></tr><tr><td>Katas</td><td>hello world</td><td>java</td><td>Fully Verified (2 of 2)</td></tr><tr><td>Katas</td><td>hello world</td><td>python</td><td>Fully Verified (2 of 2)</td></tr><tr><td>Katas</td><td>quine</td><td>ruby</td><td></td></tr><tr><td>Katas</td><td>quine</td><td>java</td><td>Fully Verified (2 of 2)</td></tr><tr><td>Katas</td><td>quine</td><td>python</td><td>Fully Verified (2 of 2)</td></tr></tbody></table>
If I use the current Thor::Shell::HTML I get HTML colors mixed with ASCII tables, resulting in:
This discussion was converted from issue #439 on May 12, 2023 22:20.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I've got a nice-to-have feature request. No bug or urgent need, but it doens't look hard to implement. I just wanted to make sure Thor::Shell::HTML is deprecated before working on a PR.
I'm not really sure who is using Thor::Shell::HTML or how they use it. I haven't seen much documentation or usage so I realize it might be partially supported.
Having said that, I have come across situations where I'd like a command I'd like to give users the option between text (Thor::Shell::Colored), Markdown or HTML output. This makes a lot of sense for the print_table command, which has:
Text tables (color not shown on GitHub)
Markdown Tables (not in original markdown, but common extension supported by GFM and others)
HTML (equivalent to GFM-rendered Markdown)
If I use the current Thor::Shell::HTML I get HTML colors mixed with ASCII tables, resulting in:
Beta Was this translation helpful? Give feedback.
All reactions