chore: rename confusing classes #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaginaris
requested review from
maureenorea-clores,
Esakkiraja-Pothikannan,
SoumenRautray,
ts-dzmitry-kurski and
ts-robih-robihamanto
as code owners
SoumenRautray
requested review from
anish-munirathinam
and removed request for
ts-robih-robihamanto and
ts-dzmitry-kurski
SoumenRautray
approved these changes
Oct 9, 2023
Current coverage for RInAppMessaging.framework is
|
| Files changed | - | - |
|---|---|---|
| Router.swift | 85.44% |
✅ |
| ModalView.swift | 90.91% |
✅ |
| RInAppMessaging.swift | 94.05% |
✅ |
| CampaignsValidator.swift | 95.70% |
✅ |
| FullScreenView.swift | 100.00% |
✅ |
| CampaignsListManager.swift | 100.00% |
✅ |
| MainContainer.swift | 100.00% |
✅ |
Powered by xcov
Generated by 🚫 Danger
imaginaris
force-pushed
the
chore/rename-classes
branch
from
b100135
to
1eea526
Compare
|
@SoumenRautray @Esakkiraja-Pothikannan @anish-munirathinam |
|
Kudos, SonarCloud Quality Gate passed!
|
@SoumenRautray can you merge this? |
Hi @imaginaris, we can merge it after the 8.1.0 IAM release or else we can merge it to a separate target branch and later rebase it . |
imaginaris
force-pushed
the
chore/rename-classes
branch
from
1eea526
to
a4afd60
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MessageMixerServicetoPingServiceas it was only responsible for dealing with ping endpoint (message mixer is a backend service name. Message mixer handles 2 more endpoints besides ping)Links
n/a
Checklist
fastlane ciwithout errorsSampleSPM/SampleSPM.xcodeprojproject