feat: Add Push Primer feature using Custom Json (RMCCX-6702) #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoumenRautray
requested review from
maureenorea-clores,
Esakkiraja-Pothikannan and
anish-munirathinam
as code owners
Current coverage for RInAppMessaging.framework is
|
| Files changed | - | - |
|---|---|---|
| UIApplication+IAM.swift | 89.06% |
✅ |
| CampaignsValidator.swift | 94.62% |
✅ |
| FullViewPresenter.swift | 96.35% |
✅ |
| CampaignData.swift | 100.00% |
✅ |
| CampaignDataModels.swift | 100.00% |
✅ |
| MainContainer.swift | 100.00% |
✅ |
| Campaign.swift | 100.00% |
✅ |
Powered by xcov
Generated by 🚫 Danger
Esakkiraja-Pothikannan
requested changes
Jul 19, 2024
| return nil | ||
| }() | ||
|
|
||
| private static let appNotificationSettingsURL = URL( |
There was a problem hiding this comment.
It could be method property of func openAppNotificationSettings(). No need of having static property so that you can do nil check for notificationSettingsURLString instead of assigning empty string.
| string: notificationSettingsURLString ?? "" | ||
| ) | ||
|
|
||
| func openAppNotificationSettings() -> Void { |
There was a problem hiding this comment.
nit: -> Void not required to be mentioned.
| @@ -56,16 +56,17 @@ internal class FullViewPresenter: BaseViewPresenter, FullViewPresenterType, Erro | |||
|
|
|||
| func loadButtons() { | |||
| let buttonList = campaign.data.messagePayload.messageSettings.controlSettings.buttons | |||
|
|
|||
| let pushPrimerButton = campaign.data.customJson?.pushPrimer?.button ?? nil | |||
There was a problem hiding this comment.
?? nil is not need if it can accept nil & no need any default value.
| urlString = UIApplicationOpenNotificationSettingsURLString | ||
| } else if #available(iOS 8.0, *) { | ||
| urlString = UIApplication.openSettingsURLString | ||
| } else { |
There was a problem hiding this comment.
else part is not required.
| @@ -32,7 +32,7 @@ internal struct Campaign: Codable, Hashable { | |||
| }.filter { !$0.isEmpty } | |||
| } | |||
| var isPushPrimer: Bool { | |||
| return data.customJson?.pushPrimer?.button != nil | |||
| return RInAppMessaging.isRMCEnvironment && data.customJson?.pushPrimer?.button != nil | |||
There was a problem hiding this comment.
change property name else move the RMC environment check to different place
| let semaphore = DispatchSemaphore(value: 0) | ||
| var authorizationStatus: UNAuthorizationStatus = .notDetermined | ||
|
|
||
| let center = UNUserNotificationCenter.current() |
There was a problem hiding this comment.
inject the UNUserNotificationCenter with custom protocol to test these feature
Tests/Tests/ViewPresenterSpec.swift
Outdated
| @@ -658,6 +658,85 @@ class ViewPresenterSpec: QuickSpec { | |||
| expect(impressionService.sentImpressions?.list).toNot(contain(.optOut)) | |||
| } | |||
| } | |||
| context("when custom json data is available in Campaign Data") { | |||
There was a problem hiding this comment.
change the description to mention "when push primer content available" context.
| @@ -90,4 +103,22 @@ internal struct CampaignsValidator: CampaignsValidatorType { | |||
|
|
|||
| return triggeredEvents | |||
| } | |||
|
|
|||
| internal func isNotificationAuthorized() -> Bool { | |||
There was a problem hiding this comment.
By default func is internal, no need to specify explicitly
ramesh-kuntamala
approved these changes
Aug 5, 2024
| @@ -21,3 +21,27 @@ extension UNUserNotificationCenter: RemoteNotificationRequestable { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| protocol UserNotificationCenter { | |||
There was a problem hiding this comment.
make use of RemoteNotificationRequestable & follow the implementation of that
| authorizationStatus = settings.authorizationStatus | ||
| semaphore.signal() | ||
| } | ||
| semaphore.wait() | ||
|
|
||
| return authorizationStatus == .authorized | ||
| switch authorizationStatus { |
There was a problem hiding this comment.
Change this to previous implementation where it was relay on .authorized else it wouldn't work when status was provisional.
|
Esakkiraja-Pothikannan
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added PushPrimer feature using Custom JSON
Added functionality to navigate to settings when authorization is previously denied
Added check for not displaying campaign if authorization is previously allowed
Added check for displaying Push Primer campaigns only for RMC users
Links
[RMCCX-6702]
Checklist
fastlane ciwithout errorsSampleSPM/SampleSPM.xcodeprojproject