Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlaylistItem.track possibly shouldn't be wrapped in Option #411

Open
kangalio opened this issue May 18, 2023 · 2 comments
Open

PlaylistItem.track possibly shouldn't be wrapped in Option #411

kangalio opened this issue May 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@kangalio
Copy link

At least when returned from Get Playlist, the field is never absent:

Screenshot_20230519_014641

Link

I'm not sure which other endpoints return payloads containing PlaylistItem - if PlaylistItem.track is optional in any of those, we probably shouldn't duplicate PlaylistItem and instead add a doc comment to BaseClient.playlist(): "the [`PlaylistItem::track`] field in this response is always Some".
@github-actions GitHub Actions
Copy link

Message to comment on stale issues. If none provided, will not mark issues stale

@github-actions github-actions bot added the Stale label Nov 15, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2023
@kangalio
Copy link
Author

Another valid inprovement suggestion lost to the relentless bug report steamroller called stale bot :'(

@ramsayleung ramsayleung added enhancement New feature or request and removed Stale labels Dec 8, 2023
@ramsayleung ramsayleung reopened this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramsayleung @kangalio