Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the examples #479

Open
0xbrayo opened this issue Apr 24, 2024 · 5 comments
Open

Update the examples #479

0xbrayo opened this issue Apr 24, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@0xbrayo
Copy link

0xbrayo commented Apr 24, 2024

So many of the examples provided are broken now. Please update, there are so many breaking changes that are not addressed.

@0xbrayo 0xbrayo added the enhancement New feature or request label Apr 24, 2024
@masakk1
Copy link

masakk1 commented Jun 17, 2024

I second this.
I'm trying to use the pagination_sync example and it's broken.

@MaximoMachado
Copy link

MaximoMachado commented Jun 19, 2024

What is the error you're encountering with pagination_sync? I ran it myself locally and it worked as expected. Give this command a try: cargo run --example pagination_sync --features="env-file cli client-ureq ureq-rustls-tls" --no-default-features

Also can you give a list of the other examples you're finding are broken?

@Jonsen94
Copy link

Just tested "auth_code".

It uses the wrong scope. "user-read-currently-playing" would be correct and works fine.

@ramsayleung
Copy link
Owner

I don't fully understand the description:

"auth_code" uses the wrong scope, "user-read-currently-playing" would be correct and works fine.

The auth_code example is using exactly the user-read-currently-playing scope:

let oauth = OAuth::from_env(scopes!("user-read-currently-playing")).unwrap();

@Jonsen94
Copy link

Yes, sorry, you are right. The code I refer to is from the comment above it (which I used for the custom callback url):

// Same for RSPOTIFY_REDIRECT_URI. You can also set it explictly:
//
// // let oauth = OAuth { // redirect_uri: "http://localhost:8888/callback".to_string(), // scopes: scopes!("user-read-recently-played"), // ..Default::default(), // }; //

Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants