Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.10] GitRepoRestrictions not defaulting the GitRepo #3079

Open
rancherbot opened this issue Nov 14, 2024 · 1 comment
Open

[backport v2.10] GitRepoRestrictions not defaulting the GitRepo #3079

rancherbot opened this issue Nov 14, 2024 · 1 comment

Comments

@rancherbot
Copy link
Collaborator

This is a backport issue for #3077, automatically created via GitHub Actions workflow initiated by @manno

Original issue body:

GitRepoRestriction resources can be used to default GitRepos and restrict their values.

Default values for GitRepo resources, configured through a GitRepoRestriction resource are not applied, although the restrictions remain functional.

  • defaultServiceAccount
  • defaultClientSecretName

See #3056

@rancherbot rancherbot added this to the v2.10.1 milestone Nov 14, 2024
@rancherbot rancherbot added this to Fleet Nov 14, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Fleet Nov 14, 2024
@manno manno moved this from 🆕 New to 👀 In review in Fleet Nov 14, 2024
@kkaempf kkaempf modified the milestones: v2.10.1, v2.10.0 Nov 14, 2024
@mmartin24
Copy link
Collaborator

mmartin24 commented Nov 15, 2024

Tested as described in #3077 (comment).
QASE link: Fleet-153:

Verified error in Rancher v2.10-4a48bc42c1fcaa2a2a40b6eb3d1f63e73524167-head with fleet fleet:105.0.0+up0.11.0 and then working when pointing to fleet image v0.11.1-rc.1:

  • Before fix:

Gitreporestriction is empty in job container and allows gitrepo to be deployed even when service account does not set right permissions:
2024-11-15_15-15

  • After fix:

Gitreporestriction is not empty and prevents gitrepo from being successfully deployed when service accounts lacks proper permissions:
2024-11-15_15-17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

No branches or pull requests

4 participants