set platform flag on rke2-runtime windows build #5321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
approved these changes
Jan 25, 2024
briandowns
approved these changes
Jan 25, 2024
|
Probably not possible to build Windows images on a Linux machine properly, and not an issue currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Set the
--platformflag on rke2-runtime windows builds to prevent it from being pushed aslinux/amd64again https://hub.docker.com/layers/rancher/rke2-runtime/v1.26.13-rc2-rke2r1-windows-amd64/images/sha256-86b5e9ebaa1a841ba3eb6c944ee2bd1d5b2701507badbd35d9f811bbe6d5c21a?context=exploreTypes of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments